I am not sure but it seems as if a user_access check would be beneficial in nodequeue_handler_field_links.inc. Only nodequeue maintainers should see this link and checking early would avoid the node_load.

CommentFileSizeAuthor
#2 nq_views.diff878 bytesgerhard killesreiter

Comments

merlinofchaos’s picture

merlinofchaos commented

This sounds very reasonable to me.

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Active » Needs work
StatusFileSize
new nq_views.diff878 bytes

Patch attached.

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Needs work » Needs review

Review, it needs review!

ezra-g’s picture

ezra-g commented
Title: user_access check missing? » user_access check missing
Status: Needs review » Fixed

Looks good to me. Finally, this is committed and fixed. I apologize for the delay!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.