The nodequeue_remove hook is not invoked in all necessary places so that it is called whenever an item is deleted from a subuqueue. It is currently invoked in nodequeue_subqueue_remove() and nodequeue_subqueue_remove_node(), but the one place where it needs to be invoked is in nodequeue_save_subqueue_order(), since this is where all items for a specific subqueue are removed and then added back in when the subqueue admin form is saved. The attached patch adds an invocation of hook_nodequeue_remove in nodequeue_save_subqueue_order().

CommentFileSizeAuthor
nodequeue_add_remove_hook.patch796 byteswonder95

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Needs review

Thanks for the patch! Marking as needs review.

ezra-g’s picture

ezra-g commented
Title: hook_nodequeue_remove hook not called in all necessary places » hook_nodequeue_remove hook not called in nodequeue_save_subqueue_order
Status: Needs review » Fixed

With the additional else if in this patch, we can change the existing last else if to simply 'else'. I re-rolled and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.