If I'm implementing a smart queue, how can I hook the delete of a queue in order to take actions based on this?

CommentFileSizeAuthor
#11 smerrill-606150-nodequeue-delete-hook.patch191.79 KBSteven Merrill
#9 nodequeue_606150_9_smartqueue_delete.patch1.4 KBpbuyle
#5 smartqueue_delete.patch1.42 KBjmather
#2 smartqueue_delete.patch1.46 KBjmather

Comments

ezra-g’s picture

ezra-g commented
Title: How to hook delete of queue in a smartqueue? » Hook for queue deletion
Version: 6.x-2.4 » 7.x-2.x-dev
Category: support » feature

Great question! The answer seems to be that you can't. It would be relatively simple to add a hook for queue deletion, probably involving nodequeue_delete(). Patches welcome :).

I'm interested to hear what kid of subqueue you're creating.

jmather’s picture

jmather commented
StatusFileSize
new smartqueue_delete.patch1.46 KB

Here is a shot at a patch. I think it is pretty simple, the only question would be if there is a better way to get the queue before the delete?

ezra-g’s picture

ezra-g commented
Status: Active » Needs review

Marking as needs review.

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

Thanks for the patch! This looks like a good start. We should probably place this new hook in the nodequeue_delete function, so that it will be called even when queues are deleted programatically, not just through the interface.

This looks otherwise commit worthy.

jmather’s picture

jmather commented
StatusFileSize
new smartqueue_delete.patch1.42 KB

Attached with api call moved to nodequeue_delete.

Let me know if that works.

Thanks.

jmather’s picture

jmather commented

Any update on getting this merged in?

Thx.

ezra-g’s picture

ezra-g commented
Status: Needs work » Needs review

Sorry, this was marked as "needs work" so I didn't see it. Hope to review this weekend. Thanks for the bump!

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

Thanks for the re-roll.

This needs a bit more work before it can be committed:

A) Since we're firing this hook in nodequeue_delete instead of nodequeue_delete_submit, the hook should probably be called nodequeue_api_queue_admin_delete
B) There's no reason to pass the empty $form_state variable.

Sorry about the delay in re-reviewing this. I can turn this around quicker with another re-roll.

Thanks!

pbuyle’s picture

pbuyle commented
StatusFileSize
new nodequeue_606150_9_smartqueue_delete.patch1.4 KB

We need this feature for one of our project. So I updated the patch from #5 updated to fit recommandation in #8.

pbuyle’s picture

pbuyle commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Component: Miscellaneous » Code
Status: Needs work » Needs review
Steven Merrill’s picture

Steven Merrill commented
Issue tags: +Simpletest
StatusFileSize
new smerrill-606150-nodequeue-delete-hook.patch191.79 KB

Patch attached with a small code style cleanup and an extra test.

This patch is totally bunk. Grr.

Status: Needs review » Needs work

The last submitted patch, smerrill-606150-nodequeue-delete-hook.patch, failed testing.

pbuyle’s picture

pbuyle commented

I fail to see what failed for the automated testing of my patch submission in #9. The log at http://qa.drupal.org/pifr/test/113444 only says "'failed to complete installation".

eric_a’s picture

eric_a commented

Fails due to #996512: D6 contrib project tests: [MySQL] Drupal installation failed..

pbuyle’s picture

pbuyle commented
Status: Needs work » Needs review
Issue tags: -Simpletest

#11: smerrill-606150-nodequeue-delete-hook.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, smerrill-606150-nodequeue-delete-hook.patch, failed testing.