Line 26-27 of nodequeue.module:
// Workflow_ng and actions module can't work together becuase of API collision.
drupal_set_message(t('Nodequeue\'s integration with workflow_ng module couldn\'t initialize as the Actions module is enabled. Actions module and workflow_ng can\'t be enabled at the same time.')); This message is displayed for all users, but should only be displayed for site admins. I don't want people visiting my site to see that after I enable a module.
This should either be called to drupal_set_message() as an error so that it won't be displayed for end users (depending on settings), and preferably it wouldn't display on every page load. Perhaps it should notify the admin after enabling the module, but then contain a notice in site status (by implementing hook_requirements) after that initial notification.
Thoughts on this?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | nodequeue.patch | 1.52 KB | robloach |
Comments
Comment #1
ezra-g commentedIndeed. Would you like to submit a patch to change this to an error message?
Comment #2
akahn commentedI could submit a patch when I find the time. Do you want to just leave this as an error that is displayed on every page load, or make it so that an error displays once and after that there is an issue in status report? The former I would have no problem writing a patch for while the latter would be a bit more involved for me.
Comment #3
ezra-g commentedAny patch to address this properly would be helpful, thanks.
Comment #4
robloachComment #5
ezra-g commentedThanks for rolling this.
I apologize for taking so long to review this patch. It doesn't apply to 6.x, so I'm marking as NW. Will credit you in the eventual commit.
Comment #6
amateescu commentedThis is unnecessary in nodequeue 6.x or 7.x because workflow-ng was replaced by rules. There's another issue concerning rules integration at #952448: Add rules events support.