Errors in nodequeue_contextual_links_view_alter() [#3166454]

I have some errors related to contextual links with Nodequeue 7.x-2.3 php 7.2 and 7.3:

Notice: Undefined index: name in nodequeue_contextual_links_view_alter() (line 509 of /home/kwbirds/public_html/sites/all/modules/nodequeue/nodequeue.module).
Notice: Trying to get property 'relationship' of non-object in nodequeue_contextual_links_view_alter() (line 509 of /home/kwbirds/public_html/sites/all/modules/nodequeue/nodequeue.module).

Obviously the error occurs when $elview->display_handler->handlers['argument']['name']->relationship is empty.

Comment	File	Size	Author
#4	3166454-4.patch	767 bytes	arx-e
#2	nodequeue-empty-relatioship-3166454-1.patch	1.53 KB	arx-e

Comments

Comment #1

20 August 2020 at 22:33

arx-e created an issue. See original summary.

Comment #2

arx-e commented 20 August 2020 at 22:54

Status	File	Size
new	nodequeue-empty-relatioship-3166454-1.patch	1.53 KB

I made this patch to define $relationship and check whether it is empty.
I don't know whether it is sound code but it works without errors in my site.

Comment #3

arx-e commented 20 August 2020 at 22:56

Status:

Active

» Needs review

Comment #4

arx-e commented 23 August 2020 at 19:01

Status	File	Size
new	3166454-4.patch	767 bytes

The first patch is not working as it was done on a windows pc and there are issues with line endings etc

Comment #5

24 August 2020 at 00:10

jenlampton committed 15dae33 on 7.x-2.x authored by arx-e

Issue #3166454 by arx-e: Errors in nodequeue_contextual_links_view_alter...

Comment #6

jenlampton

she / her

commented 24 August 2020 at 00:11

Status:

Needs review

» Fixed

Thanks @arx-e. I still had some trouble applying the second patch, but the intent was clear. I have committed the fix and given you credit.

Comment #7

7 September 2020 at 00:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #8

yookoala commented 3 November 2020 at 06:39

Hi. The merged commit 15dae333 seems perfectly fix my problem with the latest nodequeue. But it seems to have sit in the repository without publishing. So I have to manually do the patch to fix the annoying warning messages.

Is there any schedule to official release the fix? Thanks.

Comment #9

hargobind

he/him

Austin, Texas

commented 8 November 2020 at 00:47

Priority:

Normal

» Major

I just upgraded my sites with this module and my error logs are filling up with errors. I'm glad the issue has been fixed, and I'm using the dev branch for now to mitigate the errors. Can we please get a new release soon? Recommended release versions should not be producing errors.