I just updated to the latest version (7.x - 2.2) on a site we did years ago... it still seems to be working fine but the menu tab on each node seems to have disappeared.

Under the configuration settings for nodeque I have the box checked for "Create a menu tab for each node that could belong to any queues" just as it always was, but the tab still isn't there. I'm not sure what the issue could be and I don't see anyone else having this problem.

Any ideas?

Comments

branram created an issue. See original summary.

branram’s picture

Status: Active » Closed (works as designed)

I figured it out... the update requires you to indicate the content type that gets added to the Nodequeue in settings... whoops!

jenlampton’s picture

Glad you figured it out!

sergii pryma’s picture

Version: 7.x-2.x-dev » 7.x-2.2
Component: User interface » Code

The bug is there. When you save one node type, nodequeue settings of other node types are getting changed.

The problem is in the new nodequeue_form_node_type_form_submit() function:

...
   }
    else {
      $key = array_search($type, $types);
      unset($types[$key]);
    }
...

If node type $type isn't found in the queues $types then $key = FALSE;

PHP:

Bools are cast to integers, too, i.e. the key true will actually be stored under 1 and the key false under 0.

So unset($types[FALSE]) is equal to unset($types[0]).

And you Disable the first node content type from the $queue->types, whatever it is.

You should check var type of array_search() result as well.

It can be something like:

...
    }
    else {
      $key = array_search($type, $types);
      if ($key !== FALSE) {
        unset($types[$key]);
      }
    }
...
sergii pryma’s picture

Priority: Normal » Major
Status: Closed (works as designed) » Active
sergii pryma’s picture

Status: Active » Needs work
happysnowmantech’s picture

Status: Needs work » Needs review
StatusFileSize
new425 bytes

Rolled patch against 7.x-2.2 for #4. Thanks, Sergii.

  • jenlampton committed 5e1f5d8 on 7.x-2.x
    Issue #3110220 by happysnowmantech, Sergii Pryma: Prevent overwriting of...
jenlampton’s picture

Status: Needs review » Fixed

Thanks for the fix @ergii Pryma and for the patch @happysnowmantech. This has been committed and will be included in the next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.