• Giving a role "manipulate all queues" permission causes no difference in the behaviour of nodequeue.
  • Giving a role "administer nodequeue" permission doesn't change anything either (not sure exactly what this permission is meant to do).
  • Giving a role "manipulate queues" permission does work as advertised.
CommentFileSizeAuthor
#2 nodequeue.module.patch594 bytesolav

Comments

balord’s picture

balord commented

on line 1554 of nodequeue.module, $role_args is used in the db_placeholders() function, but $role_args is not defined. anymore (looks like it was last seen in 1.45 or so).

I believe it should be just $roles instead of $role_args?

olav’s picture

olav commented
Status: Active » Needs review
StatusFileSize
new nodequeue.module.patch594 bytes

Here is a patch that changes $role_args to $roles.

ezra-g’s picture

ezra-g commented
Status: Needs review » Reviewed & tested by the community

Works for me.

It also seems to resolve #167465: SQL warnings when user has manipulate queue permission. Were either of you observing SQL errors as described in that issue?

fletchgqc’s picture

fletchgqc commented

Wasn't experiencing issue #167465, sorry can't comment. Sorry I'm not even in a position to test that your patch works right now but it sounds from other comments like it does!

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks! Catch this in the next release candidate.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.