Add submit buttons to form['actions'] [#1442928]

PLEASE put form actions in an 'actions' wrapper and give them names. Docs: http://api.drupal.org/api/drupal/developer%21topics%21forms_api_referenc...

Several reasons:

The buttons are now combined and weightable together
Themes (and the Form system) can position them correctly
Extending modules will know what to alter

This is just horrible:

    $form[] = array(
      '#type' => 'submit',
      '#value' => t('Delete'),
      '#validate' => array('nodequeue_edit_queue_form_delete_validate'),
      '#submit' => array('nodequeue_edit_queue_form_delete_submit'),
    );

It doesn't even have a name! How are other modules supposed to hook into it?

Patch attached.

Comment	File	Size	Author
#10	1442928.patch	1.53 KB	SebCorbin
#10
#3	form-element-names.patch	1.23 KB	rudiedirkx
#3
	form-buttons.patch	815 bytes	rudiedirkx

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rudiedirkx CreditAttribution: rudiedirkx commented 16 February 2012 at 17:54

Almost the same goes for the operations/actions links in nodequeue_view_queues(). If you'd give them names, other modules could do something with them.

    if (user_access('administer nodequeue')) {
      $operations[] = l(t('Edit'), "admin/structure/nodequeue/$queue->qid/edit");
      $operations[] = l(t('Delete'), "admin/structure/nodequeue/$queue->qid/delete");
    }

Comment #2

amateescu CreditAttribution: amateescu commented 18 February 2012 at 01:26

Status:

Active

» Needs work

Ha, good catch about the missing names :) Can you provide a patch for operations as well?

Comment #3

rudiedirkx CreditAttribution: rudiedirkx commented 20 February 2012 at 16:37

File	Size
form-element-names.patch	1.23 KB

Ah man =)

Okay, here it is.

Comment #4

rudiedirkx CreditAttribution: rudiedirkx commented 20 February 2012 at 16:43

Actually there's another location this would be good...

      $form['nodes'][$node->nid]['edit'] = array('#markup' => l(t('edit'), 'node/' . $node->nid . '/edit', array('attributes' => array('title' => t('Edit this node')))));

You can write that without the markup element so that modules can influence it:

      $form['nodes'][$node->nid]['edit'] = array(
        '#type' => 'link',
        '#title' => t('edit'),
        '#href' => 'node/' . $node->nid . '/edit',
        '#attributes' => array('title' => t('Edit this node')),
      );

So that other modules can add #access = FALSE.

But that's tiny minor tiny and I'm not making a patch for that =)

The main issue is the biggest: form actions in an actions wrapper and named.