Closed (fixed)
Project:
Nodequeue
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 May 2011 at 11:35 UTC
Updated:
2 Jan 2012 at 16:10 UTC
Jump to comment: Most recent file
Now that machine names are committed nodequeue should be using $name rather than $qid when creating views. This is critical for exportability as block deltas are derived from the view name. Without using a machine name nodequeue block placements can not be exported reliably using context or panels.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1160024-nodequeue_views_machine_name.patch | 670 bytes | rickvug |
Comments
Comment #1
rickvug commentedAttached is a one line patch for the change. Based on what I've seen of the update we can assume that there will always be a name set for each queue. Is an upgrade path for existing block placements required? If so I guess what could be done is a check for enabled nodequeue blocks and then for each switch off the existing block and replicate the same with the new deltas.
Comment #2
damienmckennaThanks, will test it out. You might also like to get involved in #1160068: Drop all use of $qid.
Comment #3
rickvug commented@DamienMcKenna Thank you for the heads up.
Comment #4
recidive commentedI guess it will require an upgrade path, though I don't really care about default views.
What maintainers have to say about that?
Comment #5
recidive commentedThis was fixed in 7.x-3.x. See #1160068: Drop all use of $qid.
Comment #6
amateescu commentedBumping version so we know when/where this happened.