Now that machine names are committed nodequeue should be using $name rather than $qid when creating views. This is critical for exportability as block deltas are derived from the view name. Without using a machine name nodequeue block placements can not be exported reliably using context or panels.

CommentFileSizeAuthor
#1 1160024-nodequeue_views_machine_name.patch670 bytesrickvug

Comments

rickvug’s picture

Status: Active » Needs review
StatusFileSize
new670 bytes

Attached is a one line patch for the change. Based on what I've seen of the update we can assume that there will always be a name set for each queue. Is an upgrade path for existing block placements required? If so I guess what could be done is a check for enabled nodequeue blocks and then for each switch off the existing block and replicate the same with the new deltas.

damienmckenna’s picture

Thanks, will test it out. You might also like to get involved in #1160068: Drop all use of $qid.

rickvug’s picture

@DamienMcKenna Thank you for the heads up.

recidive’s picture

I guess it will require an upgrade path, though I don't really care about default views.

What maintainers have to say about that?

recidive’s picture

Status: Needs review » Fixed

This was fixed in 7.x-3.x. See #1160068: Drop all use of $qid.

amateescu’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev

Bumping version so we know when/where this happened.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.