Hi,
I suggest a little code modification to avoid several same node entry in the same subqueue.
At this moment, when you hit the ajax auto-complete add button in the admin interface, the node will be duplicated in the nodes list in the subqueue and it's only when you hit the save button than the duplicate node will be deleted.
It provide some problems when you add the node by the ajax menu in the nodequeue tab panel.
I agree than this case is rare but it happens to us.
Example : someone modify the nodequeue in the admin interface without saving (the user make all the changes before saving). During this time, another user make a modification in the queue (through nodequeue tab panel) by adding a node that is already in the node list modified by the first user. The result is than you got twice the same node in the queue list.
Patch file will be attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | nodequeue-check_dublicate_insert-1022998-2.patch | 1.95 KB | jiv_e_old |
| #1 | nodequeue-1022998.patch | 1.98 KB | Zarakay |
Comments
Comment #1
Zarakay commentedComment #2
jiv_e_old commentedSame issues:
http://drupal.org/node/1062014
http://drupal.org/node/701636
Here's my solution. The basic idea is the same, but I tried to make the code a little bit clearer and added an error handler.
Comment #3
amateescu commentedClosing as a duplicate of #593468: adding the same node more than once to a queue causes bad behavior. Will deal over there with all this node duplication madness :)