Hi,

Nodeaccess integration used to work fine on my install, with the previous nodeaccess dev release. Unfortunatly not anymore after updating.

When creating a new child node I get the following error after I hit Submit (this does not happen for parent/top nodes):

PHP Fatal error: Call to undefined function _nodeaccess_save_new() in /usr/local/www/besite/drupal/sites/all/modules/contrib/nodehierarchy/nodehierarchyaccess/nodehierarchyaccess.module on line 83

The error is right, the _nodeaccess_save_new function is no longer in the new nodeaccess release. The older dev release is no longer available however... (the latest and only dev release equals the latest stable release)

Luckily I still have it in my repository, so I can restore the module instead of just disabling it. Either way the problem is 'fixed' for me.

But, IMHO this problem should be addressed rather quickly. Or you might get even further out of sync with the nodeaccess developments (and risk being forced to drop this integration).

I can extract the old nodeaccess dev release from my repository for you, should you need it to investigate this problem.

Thank you for an, other wise, very nice module :)

Hopla

Comments

Anonymous’s picture

Anonymous (not verified) commented
Priority: Normal » Critical

+1

Is there a solution to this yet?

Marking to critical because I can't get the mod to function because of this.

scb’s picture

scb commented

I had the same problem, and I think that just commenting out the offending function calls solves the problem...
The implementation of _nodeaccess_save_new was like this:

function _nodeaccess_save_new($nid, $grants) {
  db_query("DELETE FROM {node_access} WHERE nid=%d AND realm IN ('%s')", $nid, implode("','", array_keys($grants)));
  foreach ($grants as $realm) {
    foreach ($realm as $grant) {
      $grant[] = $nid;
      db_query("INSERT INTO {node_access} (gid, realm, grant_view, grant_update, grant_delete, nid) VALUES (%d, '%s', %d, %d, %d, %d)", $grant);
    }
  }
}

...which basically saves the grants on DB, just the same thing the previous node_access_write_grants() call does... so I tried commenting out _node_access_save_new and it seems to be working fine. I don't know if there are any side effects, I have to test it thoroughly, though....

hopla’s picture

hopla commented

@sergiocaridad: can you give us an update on any possible side effects, now that you have tested this fix for a while?
@ronan: can you think of any possible side effects? If not, would you like to commit this patch?

scb’s picture

scb commented

@hopla: Still working fine, no side effects that I know of.

dgorton’s picture

dgorton commented
Version: 5.x-1.1 » 5.x-1.x-dev
Assigned: Unassigned » dgorton
Priority: Critical » Normal
Status: Active » Fixed

fixed in latest dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.