Steps to reproduce:

  • On admin/config/people/nodeaccess_password click Add Realm
  • See ID at the end of URL
  • Don't save the form
  • Go back to admin/config/people/nodeaccess_password and click Add Realmagain
  • ID at the end of URL is increased, but previous realm is not shown on the admin/config/people/nodeaccess_password list

This way, realms are saved in DB as rows with name = '' and settings = NULL.

Comments

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Assigned: Unassigned » beltofte

You are right. This is not the smartest solution :-)

I see two solutions:

  1. Keep the current architecture, but automatically set the realm name. This solves the problem with the realm not being listed on admin/config/people/nodeaccess_password. The settings will still have to be set manually.
  2. Change the architecture so clicking the button will send the user to a new path like admin/config/people/nodeaccess_password/add.

What do you think?

radimklaska’s picture

radimklaska
Primary language Czech
Location 🇨🇿Czech Republic
commented

Second is definitely better, but first is quick fix... I would say we should fix it now with first solution, than set it postponed or create new issue.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented

I fully agree. I will look at it in the weekend probably.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Status: Active » Fixed

I have committed the fix to solution 1. I will add a new issue for re-architecting the "add realm feature".

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented

See #2085443: Change the "Add realm" behaviour to avoid auto save realm.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.