The module improperly uses the t() function without placeholders. This will cause all variations with variables to be stored in the locale tables, making it unusable for translation purposes.

CommentFileSizeAuthor
#1 t_placeholders-1131512.patch8.37 KBsvendecabooter

Comments

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Active » Needs review
StatusFileSize
new t_placeholders-1131512.patch8.37 KB

Patch attached

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

It seems the patch also includes a lot of empty space removals, that were automatically done by my editor...
But i suppose you can apply those as well, as empty spaces are pretty useless anyway ;)
The real change is found in function node_tasklist_show in the drupal_set_message() calls BTW.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Needs work

There is also some misuse in node_taskslist.admin.inc. Check http://api.drupal.org/api/drupal/includes--common.inc/function/t/6 for proper use of placeholders.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Closed (fixed)

Ah, this is a great tip. Fixed the admin.inc placeholders and applied the patch manually. Thanks for making note of which function was affected since there was extra stuff in that file.