In the switch to 4.7, the "form pre" option in nodeapi was removed, without copying the code over to check for meta_perm

This patch fixes this issue.

Without this patch the CVS version of NPBR, all users see NPBR's settings in the forms...not good.

CommentFileSizeAuthor
#6 npbr-metaperm-3.patch1.13 KBac
#3 npbr-metaperm-2.patch1.15 KBac
npbr-metaperm-1.patch1.01 KBamanuel

Comments

shouchen’s picture

shouchen commented

This patch doesn't seem to work for me. I've given the role 'author' permission to change permissions on the 'book page' type of node. However, authors do not see the permissions section of the edit form. Any ideas? (I'm on 4.7.1, using latest CVS of this module + only this patch.)

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Reviewed & tested by the community » Needs work

Whilst this patch takes away permissions from those who shouldn't have them, it also denies users that should have permissions to change permissions permission. phew. Not ready to be committed

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Needs work » Needs review
StatusFileSize
new npbr-metaperm-2.patch1.15 KB

Ben has written a patch for this. Would love some testers

stevesmith’s picture

stevesmith commented

I'm trying to test npbr-metaperm-2.patch. But it's the first time I've tried to use a patch and can't work out exactly what I'm supposed to do. I take it - means remove line and + means add line? But where exactly in node_privacy_byrole.module should I put it?

Thanks
Steve

ac’s picture

ac
Primary language English
Location Perth
commented

http://drupal.org/node/60108

ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new npbr-metaperm-3.patch1.13 KB

New patch with minor path fix

amanuel’s picture

amanuel commented

ac,

thanks for spotting the missing ['#value'].

It should now work as advertised.

Jesse McCarthy’s picture

Jesse McCarthy commented

I'm new to Drupal and I don't know how this generally works, but is this patch ever going to be incoporated into the version of the module that's available for download?

charly’s picture

charly commented

Thanks guys. The lastest patch seems to work fine here!

Nice modules btw

charly’s picture

charly commented

Thanks guys. The lastest patch seems to work fine here (drupal 4.7)

Nice modules btw

jondoesdrupal’s picture

jondoesdrupal commented
Assigned: amanuel » jondoesdrupal
Status: Needs review » Fixed

Patch applied to the 4.7 branch in cvs.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)