This module have a lot of bug and don't work out of the box. Code is not clean and don't follow the coding standard, missing using of DBL to write record and filter use sprintf to contatenate string of where (no good, but work).
I fix some of this issue:

  • remove some unnecessary function (duplicate of core function)
  • apply coding standard
  • add drupal_write_record
  • fix schema error
  • add some line of comments into code

This patch is really invasive, I think can have some problem (i don't test it a lot), but it's a god point to start improvement of this module (IMHO really usefull, but without mantainer (???) ). If some one can test it and can report info about it...

CommentFileSizeAuthor
#1 node_limit-NEW2.patch39.81 KBmavimo
node_limit-NEW.patch39.87 KBmavimo

Comments

mavimo’s picture

mavimo commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new node_limit-NEW2.patch39.81 KB

Some other BUGFIX (remove debug function from hook_nodeapi($op = 'validate) ) and error into node limitation check.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Postponed

I am the new maintainer of this project (just wanted to port it to D7 but it seems D6 needs me too ^^)

Your patch is a bit too confuse for me. I already fixed a lot of bugs and made a lot of little improvments as you did but I don't know if there are things I didn't saw before finding this patch.

If you have some time, please take a look at the 6.x-1.x-dev after the next nighty build.

Thanks

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Postponed » Closed (fixed)