This module has lots of coding standard issues reported by pareview.

Here is a list of reported issues https://pareview.sh/pareview/https-git.drupal.org-project-node_form_pane...

CommentFileSizeAuthor
#6 2975055-Fix-coding-standard-6.patch54.03 KBdeepanker_bhalla
#4 node_form_panes-2975055-4.patch54.75 KBjigish.addweb
#2 node_form_panes-2975055-2.patch54.87 KBjigish.addweb

Comments

msankhala created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new node_form_panes-2975055-2.patch54.87 KB

@msankhala, Kindly review the patch attached below where I corrected all Coding standard errors as per the requirement.

thanks

msankhala’s picture

msankhala commented
Status: Needs review » Needs work

@jigish.addweb Thanks for your work but there are a couple of errors are thrown while applying this patch.

node_form_panes 7.x-1.x* git apply -v node_form_panes-2975055-2.patch
node_form_panes-2975055-2.patch:10: trailing whitespace.
Exposes node form elements as panel panes.
node_form_panes-2975055-2.patch:11: trailing whitespace.
Actually, technically we're creating ctools content types
node_form_panes-2975055-2.patch:12: trailing whitespace.
(no, not Drupal content types
node_form_panes-2975055-2.patch:13: trailing whitespace.
@see https://drupal.org/node/1197790) that panels turns into panes.
node_form_panes-2975055-2.patch:17: trailing whitespace.
Currently ctools exposes node fields and core form elements that usually
Checking patch README.txt...
Checking patch css/node_form_panes.css...
Checking patch node_form_panes.module...
error: while searching for:
 * Implements hook_form_alter().
 */
function node_form_panes_form_alter(&$form, &$form_state, $form_id) {
  // If it's the node edit form
  if (isset($form['#node_edit_form']) && $form['#node_edit_form']) {

    // Some trickery to add a custom submit handler defined by node_form_summary
    $form['node_form_summary_submit'] = array(
      '#type' => 'hidden',
      '#default_value' => 0,
    );
    // We want to run our submit handler first, before the node gets saved
    // in the regular node form submit handler
    $form['#submit'] = array_merge(array('node_form_panes_submit_node_form'), $form['#submit']);

    // More trickery to sneak a submit handler in that is controlled by a
    // node form pane ctools content type defintion
    $form['node_form_path_submit'] = array(
      '#type' => 'hidden',
      '#default_value' => 0,
    );
    // Special submit handler for the path node form pane
    $form['#submit'] = array_merge(array('node_form_panes_pathauto_submit'), $form['#submit']);

  }
}

/**
 * Form submit handler for node forms
 */
function node_form_panes_submit_node_form($form, &$form_state) {
  // If node_form_summary_submit is true we're going to do some special handling
  // to handle scheduled publishing
  if (!empty($form_state['values']['node_form_summary_submit']) && isset($form['scheduler_settings']['publish_on'])) {
    $date = strtotime($form_state['values']['date']);
    if ($date > time()) {

error: patch failed: node_form_panes.module:21
error: node_form_panes.module: patch does not apply
Checking patch plugins/content_types/node_form/node_form_attachments.inc...
Checking patch plugins/content_types/node_form/node_form_author.inc...
Checking patch plugins/content_types/node_form/node_form_book.inc...
Checking patch plugins/content_types/node_form/node_form_comment.inc...
Checking patch plugins/content_types/node_form/node_form_flag.inc...
Checking patch plugins/content_types/node_form/node_form_log.inc...
Checking patch plugins/content_types/node_form/node_form_menu.inc...
Checking patch plugins/content_types/node_form/node_form_metatag.inc...
Checking patch plugins/content_types/node_form/node_form_panelizer.inc...
Checking patch plugins/content_types/node_form/node_form_path.inc...
error: while searching for:
        if (!$block->content['path']['alias']['#default_value']) {
          $block->content['path']['alias']['#attributes'] = array('placeholder' => '<' . t('magically generated') . '>');
        }
        // This tells our submit handler to run
        $context->form['node_form_path_submit']['#value'] = 1;
      }
      if (!$conf['display_in_fieldset']) {

error: patch failed: plugins/content_types/node_form/node_form_path.inc:43
error: plugins/content_types/node_form/node_form_path.inc: patch does not apply
Checking patch plugins/content_types/node_form/node_form_publishing.inc...
Checking patch plugins/content_types/node_form/node_form_rabbit_hole.inc...
Checking patch plugins/content_types/node_form/node_form_redirect.inc...
Checking patch plugins/content_types/node_form/node_form_scheduler.inc...
Checking patch plugins/content_types/node_form/node_form_spamicide.inc...
Checking patch plugins/content_types/node_form/node_form_spamicide_field.inc...
Checking patch plugins/content_types/node_form/node_form_summary.inc...
Checking patch plugins/content_types/node_form/node_form_workbench_moderation.inc...
Checking patch plugins/content_types/node_form/node_form_xml_sitemap.inc...
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new node_form_panes-2975055-4.patch54.75 KB

@msankhala, Thanks for reviewing the patch, I worked for it & attaching a new patch with some more necessary changes I hope this works for you now. Please share your valuable feedback on the same.

msankhala’s picture

msankhala commented
Status: Needs review » Needs work

@jigish.addweb Thanks for your work on this issue but there are still many issue reported by PHPCS. My phpcs version is 3.3.2 and Drupal coder module version 8.3.1. May be you are using some other version of PHPCS or coder modue thats why it is not showing these warnings for you.

❯ node_form_panes 7.x-1.x* phpcs --standard=Drupal .

FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/node_form_panes.module
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AND 2 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
   4 | ERROR   | [x] The second line in the file doc comment must be "@file"
   5 | ERROR   | [x] Doc comment short description must be on the first line
   5 | ERROR   | [x] Doc comment short description must end with a full stop
   7 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "***********************************************************************/"
   7 | ERROR   | [x] Additional blank lines found at end of doc comment
  25 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  61 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
  87 | ERROR   | [x] Doc comment short description must be on the first line
  87 | ERROR   | [x] Doc comment short description must end with a full stop
  89 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "***********************************************************************/"
  89 | ERROR   | [x] Additional blank lines found at end of doc comment
 121 | ERROR   | [x] Doc comment short description must be on the first line
 121 | ERROR   | [x] Doc comment short description must end with a full stop
 123 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "***********************************************************************/"
 123 | ERROR   | [x] Additional blank lines found at end of doc comment
 183 | ERROR   | [x] Doc comment short description must be on the first line
 183 | ERROR   | [x] Doc comment short description must end with a full stop
 185 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "***********************************************************************/"
 185 | ERROR   | [x] Additional blank lines found at end of doc comment
 191 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 194 | ERROR   | [x] Parameter comment must end with a full stop
 196 | ERROR   | [x] Parameter comment must end with a full stop
 198 | ERROR   | [ ] Type hint "array" missing for $element
 198 | ERROR   | [ ] Type hint "array" missing for $conf
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_metatag.inc
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 58 | ERROR   | [x] You must use "/**" style comments for a function comment
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_log.inc
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
  7 | ERROR | [x] There must be exactly one blank line after the file comment
 51 | ERROR | [x] You must use "/**" style comments for a function comment
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_rabbit_hole.inc
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 57 | ERROR   | [x] You must use "/**" style comments for a function comment
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_comment.inc
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 56 | ERROR | [x] You must use "/**" style comments for a function comment
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_attachments.inc
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 57 | ERROR   | [x] You must use "/**" style comments for a function comment
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_spamicide.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 52 | ERROR | [x] You must use "/**" style comments for a function comment
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_author.inc
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
 58 | ERROR | [x] You must use "/**" style comments for a function comment
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_workbench_moderation.inc
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 67 | ERROR | [x] You must use "/**" style comments for a function comment
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_summary.inc
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
   6 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
   7 | ERROR   | [x] There must be exactly one blank line after the file comment
 222 | ERROR   | [x] Doc comment short description must be on the first line
 222 | ERROR   | [x] Doc comment short description must end with a full stop
 224 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "***********************************************************************/"
 224 | ERROR   | [x] Additional blank lines found at end of doc comment
 232 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 233 | ERROR   | [x] Parameter comment must end with a full stop
 240 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 258 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 296 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 317 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 318 | ERROR   | [x] Parameter comment must end with a full stop
 355 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 399 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 417 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 440 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_menu.inc
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 56 | ERROR   | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_panelizer.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 56 | ERROR | [x] You must use "/**" style comments for a function comment
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_publishing.inc
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 56 | ERROR | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_scheduler.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 57 | ERROR   | [x] You must use "/**" style comments for a function comment
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_path.inc
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 47 | WARNING | [ ] Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
 75 | ERROR   | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_spamicide_field.inc
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 48 | ERROR | [x] Array indentation error, expected 4 spaces but found 6
 49 | ERROR | [x] Array closing indentation error, expected 2 spaces but found 4
 91 | ERROR | [x] You must use "/**" style comments for a function comment
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_flag.inc
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 57 | ERROR   | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_book.inc
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [x] There must be no blank line following an inline comment
 56 | ERROR   | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/plugins/content_types/node_form/node_form_redirect.inc
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 56 | ERROR | [x] You must use "/**" style comments for a function comment
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mutant/Sites/htdocs/d7core/sites/all/modules/contrib/node_form_panes/README.txt
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 97 characters
 60 | WARNING | Line exceeds 80 characters; contains 92 characters
 62 | WARNING | Line exceeds 80 characters; contains 91 characters
 67 | WARNING | Line exceeds 80 characters; contains 141 characters
 68 | WARNING | Line exceeds 80 characters; contains 107 characters
--------------------------------------------------------------------------------------------

Time: 778ms; Memory: 10Mb
deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Needs work » Needs review
StatusFileSize
new 2975055-Fix-coding-standard-6.patch54.03 KB

I am uploading the patch with all the fixed issues.

To which I checked the patch #6 is applying cleanly. Here is the output:

❯ node_form_panes 7.x-1.x* git apply -v 2975055-Fix-coding-standard-6.patch

Checking patch README.txt...
Checking patch css/node_form_panes.css...
Checking patch node_form_panes.module...
Checking patch plugins/content_types/node_form/node_form_attachments.inc...
Checking patch plugins/content_types/node_form/node_form_author.inc...
Checking patch plugins/content_types/node_form/node_form_book.inc...
Checking patch plugins/content_types/node_form/node_form_comment.inc...
Checking patch plugins/content_types/node_form/node_form_flag.inc...
Checking patch plugins/content_types/node_form/node_form_log.inc...
Checking patch plugins/content_types/node_form/node_form_menu.inc...
Checking patch plugins/content_types/node_form/node_form_metatag.inc...
Checking patch plugins/content_types/node_form/node_form_panelizer.inc...
Checking patch plugins/content_types/node_form/node_form_path.inc...
Checking patch plugins/content_types/node_form/node_form_publishing.inc...
Checking patch plugins/content_types/node_form/node_form_rabbit_hole.inc...
Checking patch plugins/content_types/node_form/node_form_redirect.inc...
Checking patch plugins/content_types/node_form/node_form_scheduler.inc...
Checking patch plugins/content_types/node_form/node_form_spamicide.inc...
Checking patch plugins/content_types/node_form/node_form_spamicide_field.inc...
Checking patch plugins/content_types/node_form/node_form_summary.inc...
Checking patch plugins/content_types/node_form/node_form_workbench_moderation.inc...
Checking patch plugins/content_types/node_form/node_form_xml_sitemap.inc...
Applied patch README.txt cleanly.
Applied patch css/node_form_panes.css cleanly.
Applied patch node_form_panes.module cleanly.
Applied patch plugins/content_types/node_form/node_form_attachments.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_author.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_book.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_comment.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_flag.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_log.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_menu.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_metatag.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_panelizer.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_path.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_publishing.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_rabbit_hole.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_redirect.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_scheduler.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_spamicide.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_spamicide_field.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_summary.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_workbench_moderation.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_xml_sitemap.inc cleanly.

❯ node_form_panes 7.x-1.x* phpcs --standard=Drupal .

❯ node_form_panes 7.x-1.x*

PHPCS is reporting no coding standard warning after applying the patch #6.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

Great work @deepanker_bhalla. I can confirm the path #6 is fixing all the coding standard issue reported by PHPCS.