Problem/Motivation

PHP compatibility issue

FILE: ...app/modules/contrib/node_export/src/NodeImport.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
164 | ERROR | "$this" can no longer be used in a plain function or method
| | since PHP 7.1.
--------------------------------------------------------------------------------
FILE: .../app/modules/contrib/node_export/src/NodeExport.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
117 | ERROR | "$this" can no longer be used in a plain function or method
| | since PHP 7.1.
--------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 node_export-PHPCompatibility-3197979-1.patch749 bytesprithiraj

Issue fork node_export-3197979

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prithiraj created an issue. See original summary.

prithiraj’s picture

prithiraj commented
StatusFileSize
new node_export-PHPCompatibility-3197979-1.patch749 bytes
mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review

The patch is already applied in #2, is there anything left to do in this ?

cornifex’s picture

cornifex commented
Status: Needs review » Reviewed & tested by the community

$this is also being used in a static context here, which throws an error. I tested this patch and confirmed that the error has been resolved.

i-trokhanenko made their first commit to this issue’s fork.

i-trokhanenko opened merge request !13

i-trokhanenko closed merge request !13

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.