Some admin themes e.g. Ember use CSS selectors based on the text direction however node embed page doesn't specify this so it breaks some of the styling.

This patch simply adds the the correct attributes on the html tag.

CommentFileSizeAuthor
#8 interdiff-6-8.txt743 bytespaulvandenburg
#8 node_embed-2669682-8.patch612 bytespaulvandenburg
#6 node_embed-2669682-6.patch613 bytesimrancluster
#2 node_embed-2669682-1.patch610 bytesakbardhedhi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akbardhedhi created an issue. See original summary.

akbardhedhi’s picture

akbardhedhi CreditAttribution: akbardhedhi commented
FileSize
node_embed-2669682-1.patch610 bytes
akbardhedhi’s picture

akbardhedhi CreditAttribution: akbardhedhi commented
Issue summary: View changes
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Capgemini commented
Version: 7.x-1.2 » 7.x-1.x-dev
Assigned: akbardhedhi » Unassigned
Status: Active » Needs review
Issue tags: +Novice

Looks good to me. +1 to RTBC.

imrancluster’s picture

imrancluster CreditAttribution: imrancluster commented
Title: Include language and and text direction in popup html » Include language and text direction in popup html
imrancluster’s picture

imrancluster CreditAttribution: imrancluster commented
FileSize
node_embed-2669682-6.patch613 bytes

In the above patch need semicolon for print statement.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Capgemini commented
Status: Needs review » Reviewed & tested by the community

Looks good.

paulvandenburg’s picture

paulvandenburg CreditAttribution: paulvandenburg commented
Status: Reviewed & tested by the community » Needs review
FileSize
node_embed-2669682-8.patch612 bytes
interdiff-6-8.txt743 bytes

Thanks for the work so far, I'm planning on committing this soon.
However I'd like to see this updated to the latest HTML5 standards. See attached patch.