Problem/Motivation
The negate logic is handled with core's ConditionManager class and therefore this module shouldn't handle the negate logic within the condition plugin itself.
Proposed resolution
Remove negate logic from the condition plugin.
Add unit test to check the condition on a node that doesn't have the target field in its definition.
Issue fork node_boolean-3247629
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 8.x-1.x
changes, plain diff MR !2
- 3247629-remove-negate-logic
changes, plain diff MR !1
Comments
Comment #5
joshhytr commentedI've opened a merge request with the following changes:
Comment #7
andy_w commentedThanks for this, great work! I have no idea how I missed this.
Merged into release 1.9
Comment #8
andy_w commented