Hi, I've attached a screenshot of what the Rules UI looks like in Neptune. As you can see, there is some funny business going on with the Edit and Delete links. Also, I feel like the tables should take up the full row, yes?

Here is what I see in the Rules UI
Screenshot of Neptune running Rules UI

CommentFileSizeAuthor
#1 Screen Shot 2013-04-09 at 2.54.50 PM.png69.07 KBdiwant
#1 neptune-overrides-1960448-1.patch2.48 KBdiwant
Screenshot_4_3_13_1_37_PM.png89.49 KBdiwant
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

diwant’s picture

diwant CreditAttribution: diwant commented
Status: Active » Needs review
FileSize
neptune-overrides-1960448-1.patch2.48 KB
Screen Shot 2013-04-09 at 2.54.50 PM.png69.07 KB

I have come up with some overrides that make these pages look MUCH better. I've got my changes in a patch against the 7.x-1.x branch. Here's what the page looks like now:
Screenshot of fixed Rules UI on Neptune

I hope you agree with how I implemented this, I think it will be good and a clean way to continue in case other modules don't look right in the future.

laurencemercer’s picture

laurencemercer
Primary language English
CreditAttribution: laurencemercer commented

There are different issues here:

Table width

This is a tricky one.

Zen doesn't make tables 100% width. I'd guess that's due to:

  • table output potentially occurring anywhere (i.e. somewhere that 100% width is not appropriate)
  • it being more complicated to override the width of a table which already has 100% width than to set 100% width if you want it

So, for now, I'm going to leave table width as is and say that you should change it yourself in the CSS.

Custom styling for contrib modules

There are too many contrib modules for it to be viable to try and test/maintain contrib module specific code.

As such:

  • the Commerce help text position should be corrected either in the module or in your personal code
  • the Rules UI 'Show row heights' link positioning is due to the module's CSS. There's an open Rules issue which should resolve this: #963402: CSS: "show row weights" should remain in parent block
  • the action link spacing (e.g. 'edit', 'delete', etc.) is generic enough that it could potentially be changed in Neptune - I'll look at that in more detail
diwant’s picture

diwant CreditAttribution: diwant commented
Title: Edit and delete links in Rules UI are very close together » Action Link spacing (i.e. in Rules UI) is too little, action links are too close together
Status: Needs review » Needs work

Ok. I'll update the issue.

For the module specific stuff, I do find that panels, ctools, views, rules, etc. all seem to have strange things that need to be addressed in the themes I make over and over again, so it would be convenient to have community involvement in creating and maintaining those fixes (I assume others are fixing these same issues in their own custom code right now, right?). Yet if we are to keep the code base for Neptune smaller, then that will be a problem I will solve differently. Cheers.

laurencemercer’s picture

laurencemercer
Primary language English
CreditAttribution: laurencemercer commented
Title: Action Link spacing (i.e. in Rules UI) is too little, action links are too close together » Action links are too close together

If you're repeatedly finding CSS/styling issues with contrib module output then it sounds like there may be issues with those modules. If so, it would be best to patch the modules and resolve the issues for good, rather than keep overriding stuff in your themes.

diwant’s picture

diwant CreditAttribution: diwant commented

K

laurencemercer’s picture

laurencemercer
Primary language English
CreditAttribution: laurencemercer commented
Status: Needs work » Fixed

Fixed in the dev release.

diwant’s picture

diwant CreditAttribution: diwant commented

Nice, thanks!

diwant’s picture

diwant CreditAttribution: diwant commented

Confirming this works and I saw the ajax loader in the text bar is fixed too. Thanks! I'll be able to help with Color.module soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 64743b1 on 7.x-1.x, 7.x-2.x by laurence_m: 
    Issue #1960448 by laurence_m: Fixed action links too close together.