Storing entity storage as a class property is not recommended [#3611475]

Problem/Motivation

 ------ --------------------------------------------------------------------- 
  Line   src/ListBuilder/NameFormatListBuilder.php                            
 ------ --------------------------------------------------------------------- 
  81     Direct injection of entity storage via $storage is not recommended.  
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call        
         getStorage() at the call-site instead.                               
         🪪  drupal.entityStorageDirectInjection                              
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/ListBuilder/NameListFormatListBuilder.php                        
 ------ --------------------------------------------------------------------- 
  71     Direct injection of entity storage via $storage is not recommended.  
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call        
         getStorage() at the call-site instead.                               
         🪪  drupal.entityStorageDirectInjection                              
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Service/NameFormatterService.php                                 
 ------ --------------------------------------------------------------------- 
  96     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  97     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Service/NameOptionService.php                                    
 ------ --------------------------------------------------------------------- 
  51     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  52     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   tests/src/Functional/NameFormatterTest.php                            
 ------ ---------------------------------------------------------------------- 
  22     Class Drupal\name\NameFormatter not found.                            
         🪪  class.notFound                                                    
         💡  Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ ---------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Plugin/Field/FieldFormatter/NameFormatterTest.php     
 ------ --------------------------------------------------------------------- 
  170    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  171    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   tests/src/Unit/Plugin/diff/Field/NameFieldBuilderTest.php              
 ------ ----------------------------------------------------------------------- 
  94     Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
  94     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait.          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡  See https://www.drupal.org/node/3110266                            
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Traits/NameFormSettingsHelperTraitTest.php            
 ------ --------------------------------------------------------------------- 
  71     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   tests/src/Unit/Utility/FormattedNameTokenReplacementTest.php           
 ------ ----------------------------------------------------------------------- 
  468    Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
  468    Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait.          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡  See https://www.drupal.org/node/3110266                            
  469    Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
  469    Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait.          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡  See https://www.drupal.org/node/3110266                            
  470    Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
  470    Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait.          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡  See https://www.drupal.org/node/3110266                            
  471    Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
  471    Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait.          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡  See https://www.drupal.org/node/3110266                            
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Utility/NameOptionValidatorTest.php                   
 ------ --------------------------------------------------------------------- 
  47     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork name-3611475

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3611475-storing-entity-storage changes, plain diff MR !113
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 July 2026 at 18:24

bluegeek9 created an issue. See original summary.

Comment #2

bluegeek9 commented 16 July 2026 at 18:25

Issue summary:

View changes

Comment #3

28 July 2026 at 22:44

bluegeek9 opened merge request !113

Comment #4

29 July 2026 at 00:30

bluegeek9 committed cdd11c19 on 2.0.x

task: #3611475 Storing entity storage as a class property is not...

Comment #5

bluegeek9 commented 29 July 2026 at 00:49

Assigned:	bluegeek9	» Unassigned
Status:	Active	» Fixed


	Thank you for your contribution! Your continued support makes this project sustainable.

There are multiple ways to show appreciation for the work contributed to this project including: Triage issues and adding more context to existing issues. Flagging Name as a favorite on the project page to help others discover it and show your support. Review the Developer Documentation and Sitebuilder Documentation for accuracy and clarity.

Comment #6

29 July 2026 at 00:49

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Comment #7

12 August 2026 at 00:50

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Storing entity storage as a class property is not recommended