i have create an type-plugin for viewing weblinks as block on mysite. weblinks is a part from the Links package at http://drupal.org/project/links. A Demo can found at http://new.unsalle.de, but only for registred users. where can i submit the plugin?

CommentFileSizeAuthor
#7 weblink_revision3.patch1012 bytessuchold-it
#5 weblink_0.txt9.46 KBsuchold-it
#2 weblink.txt9.46 KBsuchold-it

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Just attach it to this issue (you'll probably have to rename it weblinks.txt).

I'll review it and add it to the tarball when it's ready.

Thanks!

suchold-it’s picture

suchold-it commented
StatusFileSize
new weblink.txt9.46 KB

Here is the weblink.inc ... thx for your great work at "mysite"

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Version: 5.x-1.9 » master
Assigned: Unassigned » agentrickard
Status: Active » Needs review

This is pretty good. I notice a few items to clean (for example, the module_exists() statement checks for Taxonomy -- it probably needs to check for the links module(s) as well.

I've also made some minor API changes going forward (these are currently in HEAD).

I'm not planning any more 5.x.1 releases, but I'll package an updated version of this file with the first 5.x.2. I hope to have that out shortly.

I may commit this to HEAD first, if so, I'll close this issue.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Postponed (maintainer needs more info)

I've been preparing this include for the 5.2 release, and I have a question.

In browsing the weblink categories (as a user), should we show all categories or just categories that contain a Weblink?

Right now it shows all.

suchold-it’s picture

suchold-it commented
StatusFileSize
new weblink_0.txt9.46 KB

sorry for my late answer,

the browsing in the weblink categories is restricted to weblinks of the links-package btw. to categories of the taxonimie that has the type Weblink.

PS: i have fixed an SQL-Errror for my type-plugin, for a problem in mysql 5 databases.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Postponed (maintainer needs more info) » Active

Can you post the fix below as a snippet or give the line number of the change?

suchold-it’s picture

suchold-it commented
StatusFileSize
new weblink_revision3.patch1012 bytes

The change was in line nummer 99 ... i have create a patch for this

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Closed (fixed)

Finally finished and documented. Will commit to HEAD later today.