While updating to Multiversion 8.x-1.0-beta1, I discovered something icky.

Update #8007 tries to read data from the revision tables for all enabled entity types (as compiled by update #8005), but it is wrongly assuming that all of those entity types actually have a revision table. If it encounters one that does, it tries to select rows from a null table and a PDOException is thrown. I'm don't know what the ultimate result of this is, but it seems reasonable to assume that it can lead to data corruption. Thus, I think this bug is critical.

I'm not sure what the proper solution would be, but a quick-fix is for the #8007 update hook to at least sanity-check that $table_revision is not empty. Patch coming shortly.

CommentFileSizeAuthor
#2 2865404-2.patch524 bytesphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Status: Active » Needs review
StatusFileSize
new524 bytes
phenaproxima’s picture

Title: Update #8007 wrongly assumes that all enabled entity types are revisionable » Update #8007 wrongly assumes that all enabled entity types have a revision table

  • jeqq committed 510f81c on 8.x-1.x authored by phenaproxima
    Issue #2865404 by phenaproxima: Update #8007 wrongly assumes that all...
jeqq’s picture

Status: Needs review » Fixed

Thank you @phenaproxima!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.