Hi,

This is an awesome module (that I'm surprised isn't a core functionality).

Are there any plans for a D8 version?

If it's the lack of dev time, I'd happily contribute my time.

CommentFileSizeAuthor
#8 drupal_8_version-2820409-8.patch6.99 KBjeroent
#7 multiple_selects_d8.patch7.11 KBjeroent
#3 multiple_selects-8.x.tar_.gz1.62 KBkhaled.zaidan

Comments

khaled.zaidan created an issue. See original summary.

khaled.zaidan’s picture

khaled.zaidan commented
Assigned: Unassigned » khaled.zaidan

I've already written something... just cleaning it up, i'll upload it shortly.

khaled.zaidan’s picture

khaled.zaidan commented
Status: Active » Needs review
StatusFileSize
new multiple_selects-8.x.tar_.gz1.62 KB

Attached is the D8 version of the module.

Tested with entity reference fields (I imagine it would work just fine with other list types, but who knows!).

Worthy for being a dev release, I think.

webadpro’s picture

webadpro commented

Ill review and get back to you.

Thanks for the files.

Having a patch could be even better :)

khaled.zaidan’s picture

khaled.zaidan commented

To be honest, I didn't know how to create a patch for D8 when there isn't even a D8 branch in the repository (especially that the code is so different from the D7 version, due to the changes in durpal's API... this work was more inspired by core's select list widget, which I'm extending in our multiple-selects widget).

In all cases, thanks for having a look :)

khaled.zaidan’s picture

khaled.zaidan commented

any update?

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new multiple_selects_d8.patch7.11 KB

@khaled.zaidan,

Thanks for your work!

I created a patch of the files you uploaded in #3 and cleaned it up a little bit.

The module works, but on submit of the node, there is still a notice.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new drupal_8_version-2820409-8.patch6.99 KB

Created a new working patch.

michaelfavia’s picture

michaelfavia commented

Thank you for the port! Tested on Drupal 8.3.0-rc1 with term references and it worked great. If we can get a dev branch we can get a few more eyeballs on this one.

@webadpro: Happy to help make it if you'd like help on the maintainer front.

webadpro’s picture

webadpro commented

Hello All,

Congrats on the patch & port.

Sorry for the delay... let me see if I can get a dev branch up & running.

webadpro’s picture

webadpro commented

I've committed the initial port and created a d8 dev branch based on JeroenT's Patch.

webadpro’s picture

webadpro commented
Assigned: khaled.zaidan » Unassigned
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Fixed

Great to here!

Let's close this issue and make separate issues for new bugs/improvements.

webadpro’s picture

webadpro commented
Status: Fixed » Closed (fixed)