Missing use strict statments
Expected === instead of ==
Few missing spaces for the functions

CommentFileSizeAuthor
#3 monitoring.patch1.79 KBpashupathi nath gajawada

Comments

Kshiteej Pitta created an issue. See original summary.

pashupathi nath gajawada’s picture

pashupathi nath gajawada commented
Assigned: Unassigned » pashupathi nath gajawada
pashupathi nath gajawada’s picture

pashupathi nath gajawada commented
Status: Needs work » Needs review
Issue tags: +JavaScript clean-up
StatusFileSize
new monitoring.patch1.79 KB

Please find the attached patch which fixes the js issues of this module

Status: Needs review » Needs work

The last submitted patch, 3: monitoring.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Closed (duplicate)

This is a duplicate of #2683375: ESLint check and verify code quality in Monitoring

Could you please review the other issue and confirm it or extend missing pieces?

CTaPByK’s picture

CTaPByK commented

Yes this is duplicate also "Needs work". I found 2 warnings/errors in this patch. First we must keep coding style uniform, so we use single quotes by default and then we have error in "use strict". Of course we always may turn off this rule by add directive /*eslint quotes: [2, "double"]*/ and use double quotes. Second is non respected rule lines-around-comment.