Problem/Motivation

Followup from
#2384601: Rename Sensor to SensorPlugin

We typehint SensorConfig a lot since a representing Interface is missing.

Proposed resolution

Create SensorConfig interface and fix typehinting.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 monitoring-2389043-add-interface-config-entity-2.patch18.63 KBAnushka-mp
#1 monitoring-2389043-add-interface-config-entity-1.patch23.21 KBAnushka-mp

Comments

Anushka-mp’s picture

Anushka-mp commented
StatusFileSize
new monitoring-2389043-add-interface-config-entity-1.patch23.21 KB

The interface was created but there are some test failures. Submitting for a review.

Anushka-mp’s picture

Anushka-mp commented
StatusFileSize
new monitoring-2389043-add-interface-config-entity-2.patch18.63 KB

Yay! Tests are green, Thanks to Sascha ;)

Anushka-mp’s picture

Anushka-mp commented
Status: Active » Needs review

The last submitted patch, 1: monitoring-2389043-add-interface-config-entity-1.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Awesome. Fixed a few minor typos / formattings.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.