Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
As a followup from renaming SensorInfo => SensorConfig, we also discussed about further renaming concepts for clarity and uniformity.
#2382539: Rename SensorInfo to SensorConfig
Discussed:
Sensor/Sensors/* => Sensor/*
Sensor.php => SensorBase.php
The SensorType rename is not fully clear as adding "Type" to all Sensor thingies results in a lot extra garbage and no real value.
In case we only do this, we should still think about what remains on Sensor for shortness...
Discussed:
Plugin/monitoring/Sensor => Plugin/monitoring/SensorType
Sensor/Sensors/Sensor*.php => SensorType*.php
Plugin/monitoring/Sensor/Sensor*.php => Plugin/monitoring/SensorType/*Sensor.php
Proposed resolution
Rename stuff and further think about DX.
Remaining tasks
Decide about SensorType name usage.
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | monitoring_2383993_rename_7.patch | 36.2 KB | miro_dietiker |
Comments
Comment #1
miro_dietikerMoved src/Sensor/Sensors/* to src/Sensor/*
file move, namespace change.
Sensor.php => SensorBase.php
Subclass names untouched.
Plugin/monitoring/Sensor/Sensor*.php => Plugin/monitoring/Sensor/*Sensor.php
Renamed the sensors
Comment #3
miro_dietikerNice. The fail is again unrelated. :-)
Additional renames...
/Sensor/Sensor*.php => /Sensor/*Sensor.php
Comment #5
miro_dietikerOK... refactoring doesn't always automatically rename everything right... ;-)
Comment #7
miro_dietikerAnd strings might containt the previous names too...
Comment #8
miro_dietikerRenaming title of more specificity.
Separating Consideration of Sensor to SensorType into followup.
Comment #9
miro_dietikerAnd pushed.