Drupalcs and other analyzers fault the mongodb.module for not having proper phpdoc blocks and other minor issues.

Also, the README.txt is long and would be more readable converted to Markdown, which AdvancedHelp + Markdown modules show quite well within a site: convert it to Markdown and improve it accordingly.

CommentFileSizeAuthor
#1 2544284-coding_standards_readme.patch28.11 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new 2544284-coding_standards_readme.patch28.11 KB

Suggested patch.

The only code change required by this standard compliance is the renaming of the semi-hidden mongoDebugCollection, mongoDebugCursor and mongoDummy classes to MongoDebugCollection, MongoDebugCursor and MongoDummy

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • fgm committed 006e78d on 7.x-1.x 
    Issue #2544284: Apply Drupal coding standards to mongodb.module.
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review. Committed to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.