"update", "delete" grants for unpublished content depend on "view revisions" permission

Locomo,

I had a disappearing "Edit" tab and it turned out the problem was the input format. If a node was created (or most recently modified) with an input format that the user does not have access to, they "Edit" tab will not appear.

Once I changed the input format to one accessible by all users, the Edit tab suddenly appeared. This appears to a result of Drupal core itself rather than the Revisioning, Module Grants, or Workflow modules.

For more details, see this thread:

http://drupal.org/node/91663

It took me a few frustrating hours to track down this answer!

Hope this helps,
Ben

You probably need some module that grants access to the author. If you have "edit own [type] content" permission disabled, then by default author won't be able to edit, unless there is access control module granting edit access.

Strange.. What you describe looks like bug. It's not intended behavior, edit permissions should not mess with "view revisions" permission. I'm going to setup similar workflow on my site soon, and will check if it works for me.

The module better formats solves this problem as it doesn't allow administrators using not-allowed formats
http://drupal.org/project/better_formats

I'm talking about my case. In my case :

- An auth user creates a content, he has the "Simple HTML" Input format permission.
- An administrator sets the content Input format to "Extended HTML" (for example) wich is not accessible by auth users. The administrator doesn't know that auth users dont have access to it.
- The auth user wich has the permission for "Simple HTML", tries to edit this content because he owns it.
- He can't edit the content because the Edit Link is not shown. If he tries to edit the node directly using node/123/edit he get an "access denied" message.

With better formats you can set the allowed input formats per node type, and when editing a node, you won't be able to set non-allowed formats even if you are an administrator, and this solves that problem.

Maybe there are some other cases that make dissapear the Edit button, but this is the solution for this case.

Confirming. It's bug in Module Grants again. It happens only with unpublished content.
Following lines in function module_grants_node_access() deny access:

  // If the node is NOT published and the user does not have "view revisions"
  // permission, deny access, UNLESS it's the author viewing the node and one
  // of the following is true:
  // o Author has "view revisions of own content" permission (see Revisioning)
  // o Author is viewing the initial draft they created.
  if (!$node->status && !user_access('view revisions', $account)) {
    if (!($op == 'view' && $account->uid == $node->uid && $account->uid > 0 &&
      (user_access('view revisions of own content', $account) || get_number_of_revisions($node->nid) == 1))) {
      return FALSE;
    }
  }

module_grants_node_access() is called with $op='update' so "$op=='view'" being FALSE is enough for function to return FALSE.

Better name

locomo, I don't know. I don't understand why these lines are there. Let's wait until Rik explains.

Rik is on holiday.

Looking forward from reading Rik's answer.

Yes I'm back -- thanks for checking on me :)
I have some changes on my local machine ready for testing and checking in....
Just really under the pump for a few more days with work....
Will get back to you soon... Promise!

locomo, crea,
You're both right... Not sure what I was thinking!
I've refactored and cleaned the code up, so much so that it might actually work now... haha!

See Module Grants and Revisioning versions 16-Dec-09.
Note that the Accessible content menu option now lives in its own module: Module Grants Monitor, which you enable as per normal on the Site building >> Modules page.

Rik