This error did happen to me most of the times. Sometimes it worked. But often you select new modules, hit save, and - nothing happens. This got on my nerves so badly I do not use the module currently, as much as I love the filtering abilities.

Am almost certain that this is a Javascript error as the module does not touch the enabling process. If this has been fixed by now please let me know.

Comments

BenK’s picture

BenK commented

SUbscribing

ktleow’s picture

ktleow commented

Having the same issue here.
Drupal 7.4

restyler’s picture

restyler commented
Priority: Normal » Critical
restyler’s picture

restyler commented

here is the similar thing reported by me: http://drupal.org/node/1166414

pauleb’s picture

pauleb commented

subscribing

Taxoman’s picture

Taxoman commented

Subscribing

greenskin’s picture

greenskin commented
Status: Active » Postponed (maintainer needs more info)

Please install/open Firebug (or an alternative) and describe any JavaScript errors listed. Module Filter doesn't affect the form in any way other than visually through theming and JavaScript visual manipulation. I can't see how Module Filter solely would be the culprit for this issue. What other modules do you have installed?

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

Same problem, to reproduce:

Start the module list inside overlay,
Go to /#overlay=admin/modules

On version 1.6:
- click a tab
- enable modules
- click another tab
- enable a modules ---> now all selections are wiped, JavaScript problem

On version 2.x dev:
- click a tab
- enable modules
- click another tab ---> the module list page reloads! all selections lost

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Postponed (maintainer needs more info) » Active

Extra note to #8: it happens only inside the Overlay module!

With overlay:
/#overlay=admin/modules --> leads to above bugs

Without overlay:
/admin/modules --> no bugs (both 1.x and 2.x branches)

Seems to be a module conflict with Overlay's JS.
I used Firebug to check what happens, no results... It's just bad JS, but no errors.

mikecar’s picture

mikecar commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Postponed (maintainer needs more info) » Active

same thing happens here. I had to disable the module by patching the system table directly, then everything starts working again. therefore, it *is* definately this module's issue, and has nothing to do with other modules. I never had this issue before. No errors reported in Firebug.

Anonymous’s picture

Anonymous (not verified) commented
Title: D7 version does not activate Modules » D7 version does not activate Modules / conflicts with Overlay JS

Thought I'd clarify in the title, there seems to be a conflict with the Overlay javascript that causes the problem.

greenskin’s picture

greenskin commented
Status: Closed (fixed) » Fixed

The way that tabs worked was by using a hash in the URL, similar to how Overlay works. When a tab is selected the hash is changed for the modules path. This, to Overlay, looked like a page change so it reloads the page.

I've actually implemented two work-arounds to this issue. The first is to add the class "overlay-exclude" to the tab <a> tags. The second lets the tabs function with or without a hash in the URL, configurable in the settings.

greenskin’s picture

greenskin commented
Status: Active » Fixed

http://drupalcode.org/project/module_filter.git/commit/9d39a3b4dba6487af...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Taxoman’s picture

Taxoman commented

#12/#13: is that commit part of the current -dev release on the project page from Nov. 24th?

greenskin’s picture

greenskin commented
Status: Fixed » Closed (fixed)

Just pushed new release 1.7 with this fix in it.

lazly’s picture

lazly commented

subscribing

My page can reproduce it with 7.x-1.7

lazly’s picture

lazly commented
Status: Closed (fixed) » Active
lazly’s picture

lazly commented
Status: Active » Closed (fixed)

Sorry guys, I missed it. The problem was this: #1812318: JS failure on overlay and beyond