Webchick was reviewing some of my code and noticed:

On 7/7/07, Angela Byron wrote:
> - You don't need hook_help case 'admin/modules#description' anymore;
> this gets taken from the .info file (this is probably a bug in
> module_builder.module)
CommentFileSizeAuthor
#1 module_builder_hook_help.patch434 bytesmlncn

Comments

mlncn’s picture

mlncn commented
Title: Generated hook_help shouldn't have 'admin/modules#description' anymore. » Generated hook_help shouldn't have 'admin/modules#description' anymore AND should have only one argument
Version: » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new module_builder_hook_help.patch434 bytes

This patch fixes the extraneous hook_help definition.

Very simple, it just deletes it. The patch applies to module_builder/templates/hooks.template

There's another problem, apparently separate, with the definition of hook_help used by module_builder: it creates a hook_help that calls for two arguments, $path and $arg, and this causes an error because hook_help should only have one argument, $section ($path). This is not the template file and I could not resolve it. I can roll a patch for that if I can be directed to where it is defined.

benjamin, Agaric Design Collective

joachim’s picture

joachim commented
Status: Needs review » Fixed

Patch committed to CVS, thanks!

> There's another problem, apparently separate, with the definition of hook_help used by module_builder: it creates a hook_help that calls for two arguments, $path and $arg, and this causes an error because hook_help should only have one argument, $section ($path). This is not the template file and I could not resolve it. I can roll a patch for that if I can be directed to where it is defined.

That's to do with the wrong hook definitions being downloaded. I committed the fix to that last week :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.