when running coder on the code that gets output, there are errors.

CommentFileSizeAuthor
#3 partial_clean-1094002-module_builder.patch1.15 KBaaronott

Comments

joachim’s picture

joachim commented
Category: task » bug
Priority: Normal » Major

Let's call this a bug :)

joachim’s picture

joachim commented

Though I have to say I'm adamant on keeping "@file foo.module" -- that's what I use to get the module basename when writing further hooks directly...

aaronott’s picture

aaronott commented
StatusFileSize
new partial_clean-1094002-module_builder.patch1.15 KB

Here is a patch to clean a few things up:

Changes
Implementation of hook_help().
to
Implements hook_help().

Cleans a couple white spaces up, but there is a white space that appears after the hook_menu that I can't find.
- function tester_menu() {[space here]

Regarding the @file $filename, I wasn't able to find where you need that filename. I was going to see if there was any other way we could change it. We could possibly write the block as
/**
* @file
* $filename
*
* Description of the file
**/

and this way it would pass the coder test.

Thoughts?

joachim’s picture

joachim commented

This may help... #1095706: Add an option for all hooks.

That way you can run the entirety of the hook templates through Coder very easily.

> * @file
> * $filename

Works for me :)
When I say I use that for writing more hooks, I mean, by hand :)
If I'm in the module code and need the module basename for something, usually writing a hook, but also just writing new functions, it's very handy to have a piece of text I can double-click and copy.

joachim’s picture

joachim commented
Issue summary: View changes
Status: Active » Fixed

This is fixed in DCB.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.