Hi,
tried to test it and got:
"Call to undefined function modalframe_parent_js() in [...]\sites\all\modules\modalframe_menu\modalframe_menu.module on line 28"

where it reads

modalframe_parent_js();

Thanks

Comments

angelmax’s picture

angelmax commented

I found that "http://drupal.org/project/modalframe"
is defined in:
http://drupal.org/project/modalframe

which is required but I have it installed and active and getting the error reported.

angelmax’s picture

angelmax commented
Category: bug » support
Status: Active » Fixed

There were missing dependencies in my installation.
I fixed by following this tutorial
http://drupal.org/node/1078080

I was able to successfully install and test this module.
It would be useful to specify in the docs the dependencies.

Thanks.

angelmax’s picture

angelmax commented
Title: Error Call to undefined function modalframe_parent_js() » Install: specify ModalFrame, JQuery and JQuery UI Dependencies
angelmax’s picture

angelmax commented
Component: Code » Documentation
Assigned: Unassigned » angelmax
OliverColeman’s picture

OliverColeman commented
Component: Documentation » Code
Assigned: angelmax » OliverColeman
Category: support » bug
Status: Fixed » Postponed (maintainer needs more info)

Hi angelmax,

How did you manage to enable modalframe_menu when modalframe wasn't enabled? And if modalframe was enabled, I'm not sure how you got the "Call to undefined function modalframe_parent_js()" error since that function is defined by modalframe (and not jquery UI etc)? modalframe is already specified as a dependency (in the .info file), and is listed under the requirements in the docs.

I wonder if perhaps you enabled them at the same time and hook_init was called on modalframe_menu before modalframe was included? This doesn't sound likely (you'd think Drupal core would include the dependencies first, and I wouldn't think hook_init would get called before all newly enabled modules were included.

In any case, I don't think I should include jquery* as dependencies as jquery is provided by core (so always included), and jquery_ui is just required by modalframe and not directly by modalframe_menu. However unlikely it is, strictly speaking modalframe might decide to drop it and use something else and modalframe_menu would still work as it just uses the modalframe API (and not the jquery_ui API).

Cheers,
Oliver

OliverColeman’s picture

OliverColeman commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)