First off, this is a fantastic module with nice, straightforward functionality.

My only observation: it seems like it might be useful to have a UI where the dimensions of the different modal sizes (small, medium, large) could be customized... any chance that something like that might be implemented?

CommentFileSizeAuthor
#1 modal_settings_ui-1686198-1.patch8.72 KBjordanmagnuson

Comments

jordanmagnuson’s picture

jordanmagnuson commented
Title: Allow customizing modal dimensions » Create UI for altering modal sizes and modal settings
Status: Active » Needs review
StatusFileSize
new modal_settings_ui-1686198-1.patch8.72 KB

Okay, I've created a patch that allows for customizing the size of the popup modals, and basic modal settings via a ui at the modal_form settings page.

Have tested on my own site with success. Please review.

frjo’s picture

frjo commented
Assigned: Unassigned » frjo

Sorry for taking my time in this issue queue. This patch look like a good addition to the module. Will test it out and commit it if all looks good.

frjo’s picture

frjo commented
Status: Needs review » Fixed

Committed this to 7-dev with some minor changes. Thanks!

jordanmagnuson’s picture

jordanmagnuson commented

Thanks for applying it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.