The module sets the variable 'minify_captured_js' while no change has occured. This leads to an unnecessary variable set leading to a clear of the variables table, in almost every page request. Given that it is used in a memcache environment, it forces a cache miss into memcache.

In our case, I'm planning to use advagg_js_compress instead of minify.

CommentFileSizeAuthor
#6 minify-fix_wrong_var_set-2419915-6.patch808 bytessokrplare
#3 minify-fix_wrong_var_set-2419915-3.patch1.05 KBichionid

Comments

ichionid’s picture

ichionid commented
Title: Minify updates variable leading memcache to cache miss and table re-build » Minify updates variable leading to cache miss and variables table re-build
ichionid’s picture

ichionid commented
Assigned: Unassigned » ichionid
ichionid’s picture

ichionid commented
StatusFileSize
new minify-fix_wrong_var_set-2419915-3.patch1.05 KB

I patched the "if conditioning"

sch2’s picture

sch2 commented

Just applied #3 and the unneeded variable_set has dissapeared.

Thanks.

mcdruid’s picture

mcdruid commented
Related issues: +#2488822: What happens when a JS file's version is "N/A"

Same issue as #2488822: What happens when a JS file's version is "N/A"

sokrplare’s picture

sokrplare commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new minify-fix_wrong_var_set-2419915-6.patch808 bytes

Patch works for me - just re-rolling the diff so it is relative the the module directory as it should be.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: minify-fix_wrong_var_set-2419915-6.patch, failed testing.

sokrplare’s picture

sokrplare commented

Looks like there aren't any tests actually setup:
"01:41:40 ERROR: Step ?Publish JUnit test result report? failed: None of the test reports contained any result"

malcomio’s picture

malcomio commented
Issue summary: View changes

I've observed a very similar issue which was causing enormous performance problems on a production site with a large database.

  • Atul Bhosale committed 96a0562 on 7.x-1.x 
    - Bug fixes
- #2226279 Failed to generate minified JS. Error: Parse...
atul.bhosale’s picture

atul.bhosale commented
Assigned: ichionid » Unassigned
Status: Needs work » Fixed
Related issues: -#2488822: What happens when a JS file's version is "N/A"

Buggy code removed, which leads to an unnecessary variable_set

atul.bhosale’s picture

atul.bhosale commented
Version: 7.x-1.x-dev » 7.x-1.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.