Drupal 12 will drop hook_module_implements_alter
Convert hooks to OOP
public function __construct(protected RouteMatchInterface $routeMatch) {
}
#[Hook('page_attachments_alter', order: Order::Last)]
public function PageAttachmentsAlter(array &$attachments) {
if ($this->routeMatch->getRouteName() == 'entity.taxonomy_term.canonical' && ($term = $this->routeMatch->getParameter('taxonomy_term')) && $term instanceof TermInterface) {
_metatag_remove_duplicate_entity_tags($attachments);
}
}
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
damienmckennaComment #4
damienmckennaLets wait for #3398796: Add PHP attributes for all plugins to be finished first.
Comment #5
nicxvan commentedComment #6
nicxvan commentedI will still push up an initial version
Comment #8
nicxvan commentedNot sure we need to postpone this, it won't conflict and it's green.
Comment #9
nicxvan commentedComment #10
damienmckennaThank you chx and nic. The MR needs to be updated from some changes I made in 2.2.x to make the tests pass again 11.3.
Comment #11
nicxvan commentedYeah I knew that would conflict actually, I did that in the widget issue too, I reverted the change, I'll keep an eye on tests.
Comment #12
nicxvan commentedComment #13
damienmckennaThe last remaining item is confirming the info files and composer.json have the correct minimum core versions noted in order for this to work, we don't want people accidentally downloading it on an older version of core that it won't work with. Any suggestions?
Comment #14
damienmckennaFor clarification, the primary OOP hooks changes went into 10.2 and 11.2 per https://www.drupal.org/node/3395575.
The question is whether any of the specific hooks only changed in 10.3 or other branches.
Comment #15
nicxvan commentedThis should be fully compatible back to at least 10.1.
The only non BC hook changes have really been themes.
Comment #16
nicxvan commentedI'll review this real quick
Comment #17
nicxvan commentedOk I pushed that up.
The root module already set the minimum 10.3
I updated all submodules to 10.1, I'm happy to bump that to 10.3 for consistency if you want.
Comment #18
nicxvan commentedComment #19
damienmckennaThanks for reviewing that. Yes, lets take the time to update the info files so they're consistent.
Have you tested on the early 11.x branches?
Comment #20
nicxvan commentedI bumped the version so they are all consistent.
I installed drupal 10.3.1
I installed every module except page variant since I don't have a dependency.
I then added it to article and updated several fields and then looked at the output and they were all printed as expected.
I also edited the configuration and that looked correct and checked there was an extended permission for the MS thing.
Comment #21
nicxvan commentedMade them strings for #3565033: Deprecate using numeric literals for 'version' in .info.yml files, require strings
Comment #23
damienmckennaCommitted! Thank you both, especially to nicxvan for all the detailed work getting it all sorted out so nicely!
Comment #26
damienmckenna