Problem/Motivation

After deleting a node with Metatag enabled as well as i18n_string, I receive the following notice:
Notice: Undefined variable: new_metatags in metatag_metatags_delete_multiple() (line 709 of /[...]/contrib/metatag/metatag.module).

Proposed resolution

The variable is never defined, but I am unsure of the purpose of this code block.

Remaining tasks

  1. Create a patch
  2. Review

User interface changes

Deleting an entity with a Metatag with the i18n_string module enable no longer results in notices.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 metatag-n2648804-2.patch743 bytesdamienmckenna

Comments

idebr created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2648804-2.patch743 bytes

Those lines aren't required, for now.

idebr’s picture

idebr commented
  1. When inserting new nodes with i18n_string enabled, Metatag inserts multiple entries into {i18n_string} even though 'Translate output' is disabled on the settings page of Metatag (admin/config/search/metatags/settings). Is this the intended behavior?
  2. The entries in {i18n_string} as mentioned in 1. are not removed when the node is deleted. Would you like me to create a followup issue for this?
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@idebr: Please open a new issue for these problems. Thanks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 2af7e11 on 7.x-1.x 
    Issue #2648804 by DamienMcKenna: Removed some unfinished code from...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2539438: Plan for Metatag 7.x-1.8 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.