Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Nov 2015 at 06:05 UTC
Updated:
26 Jan 2016 at 02:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
daniel.rolls@flightcentre.com.au commentedI propose we change the way metatag_entity_supports_metatags handles entities with only one bundle to match the behavior in the UI.
IN metatag_entity_supports_metatags before we check the option for each bundle:
See attached patch.
Comment #3
daniel.rolls@flightcentre.com.au commentedNote this fix works for our custom entities, and even though the configuration variable relating to its bundle:
metatag_enable_{$entity_name}_{$entity_name}remains set to FALSE, this doesn't present a problem because if we add another bundle later on, the option to unset this will be available through the user interface.
Comment #4
damienmckennaComment #6
daniel.rolls@flightcentre.com.au commentedHave fixed up the patch to remove the return value passed through as arg. Also removed accidental file mode change.
Comment #7
daniel.rolls@flightcentre.com.au commentedComment #8
damienmckennaThanks for fixing the patch, @rollsd. I'll try to include it in the next release.
Comment #9
damienmckennaComment #10
damienmckennaThe tests still run.
Comment #11
damienmckennaComment #12
damienmckennaCommitted. Thanks!