The metatag_metatags_save() function has a $langcode argument that used to be used to indicate which language the values would be saved for. However, when the language handling was changed in 1.0 the argument became redundant. The question is - should we break API compatibility by removing the argument and just state categorically that all values passed into the function will be saved regardless of language, or change the function so that if the value is passed in then only that language's values will be updated? Either which way, it's certainly a confusing point in the API.

CommentFileSizeAuthor
#2 metatag-n2493689-2.patch4.87 KBdamienmckenna

Comments

damienmckenna’s picture

Title: metatag_metatags_save() ignores $langcode value » metatag_metatags_save() ignores $langcode argument
damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new4.87 KB

Removed it and the $old_vid variable, neither of which were actually used.

damienmckenna’s picture

damienmckenna’s picture

Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 40aeb2a on 7.x-1.x
    Issue #2493689 by DamienMcKenna: Removed two arguments from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.