Just wanted to note that the "Messaging plain text" input format and saved Messaging variables are not removed when the module is uninstalled.

Comments

jose reyero’s picture

Priority: Normal » Minor

Right, to be fixed, low priority though (patches welcomed)

jaydub’s picture

Status: Active » Needs review
StatusFileSize
new1.44 KB
new842 bytes

I'm not testing with 6.x just yet and don't want to change the
version of this issue but here are my patches for 5.x.

I'll try to find time to check out 6.x

jose reyero’s picture

This seems to cause an error when reinstalling too #316574: Duplicate input format on reinstall. It is the same issue though so merging both in this one.

Completely uninstalling messaging and reinstalling results in the following error message:
user warning: Duplicate entry 'Messaging plain text' for key 2 query: INSERT INTO filter_formats (name, cache) VALUES('Messaging plain text', 0) in /modules/messaging/messaging.install on line 60.

Babalu’s picture

subscribe

jose reyero’s picture

Status: Needs review » Fixed

Fixed for both versions 5.x and 6.x

Thanks for the patch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

held69’s picture

Version: 6.x-1.x-dev » 6.x-1.1
Priority: Minor » Normal
Status: Closed (fixed) » Active

I installed messaging 6.x-1.0, deinstalled it and installed messaging 6.x-1.1.
Note:combined messaging with notifications 6.x-1.0 and 6.x-1.1.

After enabling i got this message:

user warning: Duplicate entry 'Messaging plain text' for key 2 query: INSERT INTO filter_formats (name, cache) VALUES('Messaging plain text', 0) in modules/messaging/messaging.install on line 78.

I'm using Drupal 6.10

Do i need to apply a patch as well.
If so, where to get the patch, and how to apply it?

jose reyero’s picture

Status: Active » Closed (fixed)

> I installed messaging 6.x-1.0, deinstalled it and installed messaging 6.x-1.1.

As it was 6.x-1.0 uninstall script that was broken, it is normal you get some warnings...

Please reopen only if it still happens with latest version (but not after installing old *broken* ones).

held69’s picture

thanks