Closed (fixed)
Project:
MenuTree
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
24 Jun 2008 at 15:54 UTC
Updated:
10 Jun 2009 at 19:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Crell commentedNew features will only go into the 6.x version.
I am not entirely clear what the use case here is. I'm not against it, I suppose, but I'm curious why it would be needed.
Comment #2
Anonymous (not verified) commentedsitemap/all works great in dev version, thanks.
Comment #3
Crell commentedYeah, I had a client ask for that at some point. It needs to be ported forward to the D6 version, then both need a stable release to include it. Anyone want to do the D6 port of that feature? :-)
Comment #4
Anonymous (not verified) commented+1 for this functionality!
Then it will make it a great sitemap.
@msn
What do you mean with 'sitemap/all' ?
Comment #5
Anonymous (not verified) commentedJoepH:
Oehh...., What I remember.
The sitemap/all issue is outdated. In an older version you could not create a complete sitemap, only the dev version (at that time) owned this feature. It this moment the dev version is an official release.
With compliments to the module developer(s).
Martin
Comment #6
eabrand commentedHere's a patch for D6
Comment #7
eabrand commentedI have an update to the previous patch
Comment #8
Crell commented- It looks like the patch has tabs in it instead of two-spaces for indentation. All Drupal code should use two-space indentation.
- The indentation is off in menutree_display_all().
- The default weight for menus in the "all" page is set to none, so no menus will show until the admin page has been submitted. However, the defaults on the admin page are to show, in increasing order. That creates a disconnect if you're just looking at the admin page but haven't submitted it. We should probably normalize those to none in both cases for consistency.
- The if-else in menutree_display() should have the else on its own line:
- I'm unclear why you're switching the constants from a bitwise check to an equality check.
Comment #9
eabrand commentedHere is the updated patch
Comment #10
Crell commentedCommitted #9. Awesome!