Currently on 8.x-1.0, any role with the `access administration pages` permission is able to view and alter the configuration page located at `admin/config/menu-item-role-access`. In cases where editor roles have access to the administration pages, they shouldn't be able to alter these settings. A new permission should be built to allow access to the configuration page for this module for the appropriate roles.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | permission-to-view-configuration-page-3048543-6.patch | 512 bytes | Vlad Stratulat |
| #4 | menu_item_role_access-config-permission-3048543-4.patch | 1.05 KB | drieder |
| #2 | menu_item_role_access-config-permission-3048543-2.patch | 1.03 KB | drieder |
Comments
Comment #2
drieder commentedAdded a initial patch
Comment #3
liampower commentedHi @drieder,
Thanks for picking up on this, I agree it shouldn't be the `access administration pages`.
Thank you also for the patch. My only query would be the name and title of the permission. I feel Administer would be a better word to use than access.
Comment #4
drieder commentedSorry about the delay, thanks for your response @LiamPower. I've added a new patch with better wording!
Comment #5
Vlad Stratulat commentedI believe that changing it to Drupal's Administer site configuration which available by default, should be enough for this.
You don't want to spam with configuration specific checkboxes on permissions page when this is a site configuration.
- _permission: 'access administration pages'
+ _permission: 'administer site configuration'
Comment #6
Vlad Stratulat commentedComment #7
charginghawk commentedI prefer the approach in #4 - a cursory glance of my installed contrib modules shows that using "administer site configuration" is pretty rare (4 modules) and defining your own administer permission is pretty common (a few dozen modules). Also there's a "need and not have worse than have and not need" thing IMO.
It applies and works as expected.
Comment #8
liampower commented#4 is also my preferred approach, but than you for your input Vlad.
Comment #10
liampower commentedCommitted to the 1.x dev branch.
Thank you for your input everyone.