When I create an folder named «Ernie & Bert» the transliteration of the Tax Term changes it to "ernie-bert", but no folder with the name «ernie-bert» will be created. That is one issue.
And after «Add file(s)» the URIs to the thumbnails etc. go like «**/ernie%20&26%20bert/*.jpg».
If I use «transliterated» Folder Names I do not have any greater problem. But how do I communicate that to the simple and very lazy people?
Actually: Media Browser Plus is great stuff.
Kind regards
Hans

Comments

das-peter’s picture

das-peter commented
Status: Active » Postponed (maintainer needs more info)

I don't know why transliteration of the Tax Term happens for you, for me «Ernie & Bert» stays «Ernie & Bert».
And as far as I know the transliteration module doesn't deal with taxonomy term names at all.
The only thing that's transliterated in MBP is the path in the filesystem to ensure only valid paths are used (file_create_filename is used to do so).
Relating to all that I'm not sure if I really understand what you're talking about.
If you could provide more information I'll hopefully able to provide better support.

Snakehead’s picture

Snakehead commented

Hello Peter
As I do remember I uploaded the files into the media root. And then I dragged the files into the «Ernie & Bert»-Folder. The files lost then the reference to the thumbnails. I supposed some days ago that it was a problem because of the escaped folder name.
I added now the «Ernie & Bert»-Pictures again (Plupload), but this time with the Option «Ernie & Bert»-Folder. The Picture are shown in the Ernie&Bert-Folder but physically loaded into the Media root and not in the Ernie&Bert-Directory.
When I drag the images in MBP from the media root into the Ernie&Bert-Folder the images are now loaded into the Ernie&Bert-Folder but looses their reference to the thumbnails. I have then to drag it back.
This is a little bit confusion. Or did I have forgotten something?
Greetings from a Winterthurian

das-peter’s picture

das-peter commented
Title: Creating Folders without Transliteration » Changing the folder in the file entity isn't reflected in the filesystem
Status: Postponed (maintainer needs more info) » Fixed

I think I've found the issue. I forgot to add a hook that moves the file in the filesystem if the file entity is updated outside of MBP.
So it's not related to transliteration or the folder path at all.
I've added test coverage for this now and committed the new tests and fix.
Would be great if you could checkout the latest code from the repository and test if the problem is solved for you too.

Snakehead’s picture

Snakehead commented

Hallo Peter
Thank you very much for your effort. For sure I will check the latest code and give you a feedback.
At first i have to get into Git. This may take a while.
I wish you a very pleasant day.
Hans Peter

Snakehead’s picture

Snakehead commented

Hello Peter
Yes, it works almost as expected. If the files are uploaded with the current version of MBP it is possible to drag the files into another folder even the files are referenced in a node (e.g. Image Gallery). Really Great Stuff, congratulations.
But the files are still uploaded into the media Root and not in the designated folder, even specified in the plUpload-Dialog and the file type information-Dialog. If dragged within MBP the files are moved physically into the designated folder (great!). Actually there is no need for the Media Folder Option in the Plupload Dialog and the file type info dialog.
I've found another issues, but I am looking for it at first in the issue forum.
Very kind regards
Hans Peter

das-peter’s picture

das-peter commented

I've tested extensively again - I found this #2008430: file_destination() shouldn't rename the file if a directory with the same name exists. but besides that everything worked as expected.
Files were stored in the requested folder - the only exception was when a folder with the same name as the file existed in the destination, but that's something we can't fix without re-writing parts of core.
Scenarios:

  • Text / image files
  • Dedicated media folder / direct to public://
  • Plupload enabled / disabled
  • Folder with same name as the file in the destination path

I can't imagine any other scenario in which the upload could change the behavior - except other modules that interfere with it.
So I'll keep the status fixed until I get a reproducible scenario.

Snakehead’s picture

Snakehead commented

Hmmm! My private Site I use also for testing new modules. The files directory was not virgin.
I will keep an eye on it in my other projects and give you then a feedback.
Thanks for your valuable efforts. I hope your testing was not for nothing.
Best greetings from Zurich
Hans Peter

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.