Several functions in media.module under the Media Hook Implementations section should be moved to a separate module.

Specifically it looks like at least media_media_register and media_display_user_files functions should be moved (if not the other functions in the same area) to the media_upload module.

Tying into this I have questions on how http://drupal.org/node/33482 and http://drupal.org/node/353458 may affect how the files table is used. I.E. do we flat out want the various modules to deal with the database themselves and be responsible for managing it and providing file lists, or do we at some point want to provide a generic interface using the files table for the simpler modules.

Comments

jmstacey’s picture

See commit #220130

I have moved media_media_register to media_upload as part of its registration process in hook_media_register. media_display_user_files is also now in media_upload as media_upload_user_files_select().

I'm leaving this issue open until I can evaluate media_elements() and the three media_file_list_element_ callbacks.

pwolanin’s picture

Version: 6.x-1.x-dev »
aaron’s picture

Status: Active » Fixed

no longer applies.

Status: Fixed » Closed (fixed)
Issue tags: -gsoc, -gsoc2009, -gsoc2009-jmstacey

Automatically closed -- issue fixed for 2 weeks with no activity.