die() usage should be replaced by exit()

for that matter, maybe it should follow the format at http://api.drupal.org/api/drupal/modules--file--file.module/function/fil... -- looks like things have improved in d7?

At present, I don't even see where this callback is being used :(

Using the ajax_deliver requires that this be used in conjunction with the AJAX framework AFAICT, which means anything using it expecting "normal" json will fail.

Can we just remove this if it isn't in use anywhere?

I also don't see where this is being used either. I'll test removing it completely.

I've tried to find a use of this callback and didn't find anything. But I may have missed something. Here is what I've found:

1. The media_preview_ajax callback is called from media.module (line 231)

$items['media/js'] = array(
    'page callback' => 'media_preview_ajax',
    'access callback' => 'media_access',
    'access arguments' => array('view'),
    'type' => MENU_CALLBACK,
    'file' => 'includes/media.pages.inc',
  );

2. Searching the files for "media/js" didn't lead to anything so I looked for "url:" since media_preview_ajax check for a $_GET variable of this name. I've found that media.library.js makes an ajax call at line 76:

$.ajax({
    url: this.settings.getMediaUrl,
    type: 'GET',
    dataType: 'json',
    data: this.params,
    error: errorCallback,
    success: gotMedia
  });

3. getMediaUrl is referenced twice with this:
'getMediaUrl' => url('media/browser/list'),

With these results I simply deleted the menu declaration in media.module and the callback. After a drupal cache clear and some tests I haven't noticed any broken piece.

I applied patch to 1.x and tested uploading and selecting from library. Both worked fine for me.

Tested against 1.x everything seems to work just fine

Setting to re-test.

Re-rolled patch from git

Looks good then.

Looks like 2.x already removed media_preview_ajax() so it only needs the menu item removed. Here is a separate patch for 2.x

Tested on 2.x,everything still works
So we have #10 for 1.x and #12 for 2.x

from http://drupalcode.org/project/media.git/blobdiff/55a3ab29bb60cdc241fc1a3... :

 function media_menu() {
-  // AJAX formatter. This page is used to create the formatter form
-  // when adding a new file, after selecting a file and pressing 'Add'.
-  $items['media/js'] = array(
-    'page callback'    => 'media_ahah_formatter_load',
-    'access arguments' => array('access content'),

doesn't work like that anymore. kill it!

Committed to 1.x and 2.x