You guys managed to commit something that doesn't work at all !

Issues:
- the logic for alt_login requires name to be defined! Since you just cut&pasted one of my lines, the result doesn't make sense.
The select never works.

- if you don't patch the auto-select part as well, the patch is of little use anyways, as you have to enter alt_login stuff manually...

CommentFileSizeAuthor
#10 287496_alt_login_integration_10.patch2.16 KBdeviantintegral
#8 287496_alt_login_integration.patch1.8 KBdeviantintegral
#2 masquerade.patch2.7 KBespie
#1 masq.diff2.81 KBespie

Comments

espie’s picture

espie commented
StatusFileSize
new masq.diff2.81 KB

patch attached, that makes it work with 1.2...

espie’s picture

espie commented
Version: 5.x-1.2 » 6.x-1.0
StatusFileSize
new masquerade.patch2.7 KB

Fixed patch for 6.x, since I switched.

With this one, both auto-complete and actual changes work.

I think it's simpler than what's currently in.

deekayen’s picture

deekayen commented
Status: Active » Postponed

#521444: Store user ID's instead of user names for quick switch links is a prereq to this

deviantintegral’s picture

deviantintegral commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Postponed » Needs work

Patch no longer applies.

espie’s picture

espie commented

sigh, I'll work on another patch tomorrow.
But please stop postponing it or applying it in weird ways, it's a bit like having to fix the same bug over three times. It is getting annoying...

deviantintegral’s picture

deviantintegral commented

For sure - your patches are appreciated. I'd like to get this in to the next release of the module.

deviantintegral’s picture

deviantintegral commented
Assigned: Unassigned » deviantintegral

I have an updated patch (untested) for this which I'll be posting later today.

deviantintegral’s picture

deviantintegral commented
Status: Needs work » Needs review
StatusFileSize
new 287496_alt_login_integration.patch1.8 KB

Here is an updated patch - can you let me know if it works for you?

deviantintegral’s picture

deviantintegral commented
Assigned: deviantintegral » Unassigned
deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 287496_alt_login_integration_10.patch2.16 KB

Here is a rerolled patch, with a minor code style change.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

I've committed this patch as it's works for me and is needed to fully fix the Anonymous users issue.

espie’s picture

espie commented
Status: Fixed » Closed (fixed)

sorry for not giving you feedback earlier. I got swamped in other issues.
Things appear to work just fine. Thanks a lot !