Problem/Motivation

Upgrade Status Report:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Markup 8.x-1.x-dev
Scanned on Fri, 04/24/2020 - 11:41.

1 warning found.

web/modules/contrib/markup/markup.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to                  │
│ manually │      │ markup.info.yml to designate that the module is compatible │
│          │      │ with Drupal 9. See https://drupal.org/node/3070687.        │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Proposed resolution

Add the 'core_version_requirement' key to markup.info.yml

Remaining tasks

Submit patch

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

Drupal 9 support is added.

CommentFileSizeAuthor
#11 markup-drupal9_support-3130680-7.patch560 bytesgmercer
#10 markup-drupal9_support-3130680-6.patch558 bytesgmercer
#5 interdiff-2-5.txt293 byteshardik_patel_12
#5 markup-drupal9_support-3130680-5.patch565 byteshardik_patel_12
#2 markup-drupal9_support-3130680-2.patch299 byteschris burge

Comments

Chris Burge created an issue. See original summary.

chris burge’s picture

chris burge commented
Status: Active » Needs review
StatusFileSize
new markup-drupal9_support-3130680-2.patch299 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: markup-drupal9_support-3130680-2.patch, failed testing. View results

chris burge’s picture

chris burge commented
Status: Needs work » Needs review

Setting back to 'Needs review'. Tests failed because automated testing is set up with no tests.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new markup-drupal9_support-3130680-5.patch565 bytes
new interdiff-2-5.txt293 bytes

patch #2 applies cleanly and installed this on Drupal 9 instance.

Ran drupal-check and found no issues:

drupal-check -ad modules/contrib/markup                                                  
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors

But when i ran it has some changes for markup.module file 

vendor/bin/rector process modules/contrib/markup --dry-run                                        
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

 12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

1 file with changes
===================

1) modules/contrib/markup/markup.module

    ---------- begin diff ----------
--- Original
+++ New
@@ -21,4 +21,3 @@
     unset($form['cardinality_container']);
   }
 }
-

SO including this changes also. Kindly review a new patch.

Status: Needs review » Needs work

The last submitted patch, 5: markup-drupal9_support-3130680-5.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
john cook’s picture

john cook commented
Status: Needs review » Reviewed & tested by the community

I've had a look at these patches. Both add the core_version_requirement key in the info.yml file. The patch in comment #5 also fixes a coding standards bug.

The both apply cleanly and otherwise look good.

I'm setting this to RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 compatibility
gmercer’s picture

gmercer commented
StatusFileSize
new markup-drupal9_support-3130680-6.patch558 bytes

I rolled a new patch for 8.x-1.0-beta1.

gmercer’s picture

gmercer commented
StatusFileSize
new markup-drupal9_support-3130680-7.patch560 bytes

Updating the previous attempt at patching 8.x-1.0-beta1.

piyushsms91’s picture

piyushsms91 commented

I have re-test the patch it is working as expected. #11 patch is compatible with the Drupal 9 versions, it is not giving any error while installation functionality is also working fine.

piyushsms91’s picture

piyushsms91 commented
Assigned: Unassigned » piyushsms91
piyushsms91’s picture

piyushsms91 commented
hardik_patel_12’s picture

hardik_patel_12 commented
Status: Reviewed & tested by the community » Needs work

Patch is getting failed to apply , so moving back to Needs to Work.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Closed (duplicate)

Duplicate of #3141024: Automated Drupal Rector fixes which as already been committed. Closing as duplicate.