mandrill_get_api_object() returns FALSE if there is no API key set.
mandrill_sender_plain() invokes message_send() method on the return-value of that function without first checking to see that it is an object.
this causes a fatal
instead we should thow an exception, and let that be handled properly by the caller.

CommentFileSizeAuthor
#1 2228079-mandrill-sender-plain-fatal.patch614 byteswodenx

Comments

wodenx’s picture

wodenx commented
Status: Active » Needs review
StatusFileSize
new 2228079-mandrill-sender-plain-fatal.patch614 bytes
gcb’s picture

gcb
he/him
Location Portland, OR
commented
Status: Needs review » Closed (fixed)

thanks! added to dev.

  • Commit 7e5b02d on 7.x-1.x authored by wodenx, committed by gcb: 
    #2228079: Fatal error when no API key defined.
wodenx’s picture

wodenx commented

We just discovered that the same issue exists in mandrill_template_sender() (mandrill_template.module, lines 192ff)

  • Commit 7e5b02d on 7.x-1.x, 7.x-2.x authored by wodenx, committed by gcb: 
    #2228079: Fatal error when no API key defined.