FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\mailsystem\tests\modules\mailsystem_test\mailsystem_test.info.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
1 | WARNING | "Description" property is missing in the info.yml file
--------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#12 interdiff_2-12.patch778 bytespooja saraah
#12 Description-property-is-missing-3298760-12.patch657 bytespooja saraah
#4 Screenshot from 2022-07-25 02-25-39.png90.24 KBakshaydalvi212
#2 Description-property-is-missing-3298760-2.patch456 bytesHarsh panchal

Issue fork mailsystem-3298760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new Description-property-is-missing-3298760-2.patch456 bytes

I have fixed this issue and providing a patch.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Harsh panchal » akshaydalvi212

Hello @Harsh panchal,

Thanks for the patch, I will review the patch.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2022-07-25 02-25-39.png90.24 KB

Hello @Harsh panchal,

After applying the above patch: Description-property-is-missing-3298760-2.patch
It eliminates the warning mentioned above.

hence shifting the issue status to reviewed and tested by the community.

Thanks and regards

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu opened merge request !7

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: Bug report » Task
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs review
tr’s picture

tr commented
Status: Needs review » Needs work

Yes, the description property is missing in the .info.yml file of the test-only module "mailsystem_test".
But the patch doesn't add a valid description - it just copies the description from the main mailsystem module.

A valid description should describe what the test-only module does. I would rather have no description than have a wrong description.

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Needs work » Needs review
tr’s picture

tr commented
Status: Needs review » Needs work

Did not address #8.

pooja saraah’s picture

pooja saraah commented
Status: Needs work » Needs review
StatusFileSize
new Description-property-is-missing-3298760-12.patch657 bytes
new interdiff_2-12.patch778 bytes

Addressed comment #11 Made improvements to the description of the mailsystem_test module.

Applied the previous patch.
Made some follow-up changes.
Interdiff attached for review.