Closed (duplicate)
Project:
Mail System
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Mar 2018 at 16:22 UTC
Updated:
12 Aug 2018 at 20:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
emartoni commentedPatch attached!
Best,
Eduardo
Comment #4
emartoni commentedSorry, wrong patch attached!
Best,
Eduardo
Comment #5
emartoni commentedComment #6
Aanal.addweb commented@emartoni, Thanks for all your efforts, Your changes works as per the standard issues shown in Parteview.sh.
I found that you missed to perform some of the standard changes that are shown in Pareview report. Please find my attached screenshot, in which I mentioned the missed points.
Can you please Do the needful.
Comment #7
emartoni commentedHi @dhwani.addweb, how are you?
Screenshot 1 - Can't find this issue. Even after run pareview.
Screenshot 2 - Fixed.
Screenshot 3 - The readme follows the structure proposed by the author of the module. I think it's better to open a separate issue to suggest this updates. What do you think?
Best,
Eduardo
Comment #10
tr commentedThis is a duplicate of #2858676: Fix coding standards violations. Please contribute to that issue if you want to see these things fixed.